conformance ProvenCompactCiphertextList #1602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmontaigu
reviewed
Sep 30, 2024
| @@ -141,6 +146,74 @@ impl ProvenCompactCiphertextList { | |||
| } | |||
| } | |||
|
|
|||
| pub struct ProvenCompactCiphertextListConformanceParams { | |||
| pub sk_params: ClassicPBSParameters, | |||
| pub elements_per_block: usize, | |||
There was a problem hiding this comment.
Could this be called elements_per_list/elements_per_vec/elements_per_sublist, I think block may be too confusing with integer blocks
IceTDrinker
reviewed
Sep 30, 2024
Comment on lines
+393
to
+395
| let params: crate::shortint::ClassicPBSParameters = | ||
| crate::shortint::parameters::PARAM_MESSAGE_2_CARRY_2_KS_PBS_TUNIFORM_2M64; | ||
| let config = crate::ConfigBuilder::with_custom_parameters(params); |
There was a problem hiding this comment.
need a test case with casting
IceTDrinker
reviewed
Sep 30, 2024
Comment on lines
+204
to
+206
| if !proof.is_valid() { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
this API name is confusing, so more "content_is_usable"
|
this has been merged as part of the release_pr_stack branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.