Release pr stack #1608
Merged
Release pr stack #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeul-zama
requested review from
IceTDrinker,
nsarlin-zama and
tmontaigu
and removed request for
IceTDrinker
IceTDrinker
reviewed
Sep 30, 2024
Comment on lines
194
to
197
| fn is_conformant(&self, parameter_set: &Self::ParameterSet) -> bool { | ||
| let Self { glwe_ciphertext } = self; | ||
|
|
||
| glwe_ciphertext.is_conformant(parameter_set) |
There was a problem hiding this comment.
check power of 2 here for the polynomial size (equivalent to the lwe dim) and that the GlweDim = 1
IceTDrinker
reviewed
Sep 30, 2024
| let Self { | ||
| seeded_glwe_ciphertext, | ||
| } = self; | ||
|
|
There was a problem hiding this comment.
same here we need to check that the lwe dim is a power of 2 and glwe dim = 1 before chekcing the glwe
mayeul-zama
force-pushed
the
release_pr_stack
branch
from
6c5758f
to
dcfa614
Compare
|
👍 |
mayeul-zama
force-pushed
the
release_pr_stack
branch
from
dcfa614
to
a3b3b14
Compare
IceTDrinker
approved these changes
Sep 30, 2024
mayeul-zama
force-pushed
the
release_pr_stack
branch
from
a3b3b14
to
994e87a
Compare
IceTDrinker
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.