feat(integer): improve scalar_mul #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slab-ci cpu_fast_test |
tmontaigu
force-pushed
the
better-scalar-mul
branch
from
8954b7b
to
3c8088d
Compare
|
@slab-ci cpu_fast_test |
tmontaigu
force-pushed
the
better-scalar-mul
branch
from
3c8088d
to
77b3662
Compare
|
@slab-ci cpu_fast_test |
tmontaigu
force-pushed
the
better-scalar-mul
branch
from
77b3662
to
9225d65
Compare
|
@slab-ci cpu_fast_test |
tmontaigu
force-pushed
the
better-scalar-mul
branch
from
9225d65
to
ab3037c
Compare
|
@slab-ci cpu_fast_test |
tmontaigu
force-pushed
the
better-scalar-mul
branch
from
ab3037c
to
f44f0ad
Compare
|
@slab-ci cpu_fast_test |
|
@slab-ci cpu_fast_test |
IceTDrinker
reviewed
Sep 21, 2023
IceTDrinker
approved these changes
Sep 21, 2023
|
Pull Request has been approved 🎉 |
This changes the algorithm for scalar_mul. The new algorithm allows to remove a lot of work. For small precisions (16, 32, 64) the gains are in range 5%-10% for higher precisions the gains are 25%-50%. This also changes the mul to use the functions that sums many clean ciphertexts in parallel. For mul, there is only a 5%-10% improvements for 128bits and 256bits mul.
tmontaigu
force-pushed
the
better-scalar-mul
branch
from
f44f0ad
to
006cc63
Compare
|
@slab-ci cpu_fast_test |
|
what's the diff on your last push ? |
|
Just rebased on top of the fix to the signed_div_rem test in the case of doing 0/0 |
IceTDrinker
approved these changes
Sep 22, 2023
|
Pull Request has been approved 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR content/description
This changes the algorithm for scalar_mul.
The new algorithm allows to remove a lot of work.
For small precisions (16, 32, 64) the gains are in range 5%-10% for higher precisions the gains are 25%-50%.
This also changes the mul to use the functions that sums many clean ciphertexts in parallel. For mul, there is only a 5%-10% improvements for 128bits and 256bits mul.