Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add end-of-file newline checks recipe #554

Merged
merged 3 commits into from
Sep 20, 2023
Merged

chore(ci): add end-of-file newline checks recipe #554

merged 3 commits into from
Sep 20, 2023

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Sep 14, 2023

Resolves: zama-ai/tfhe-rs-internal#24

@soonum soonum added the ci label Sep 14, 2023
@soonum soonum self-assigned this Sep 14, 2023
@cla-bot cla-bot bot added the cla-signed label Sep 14, 2023
@github-actions
Copy link

@slab-ci cpu_fast_test
@slab-ci code_coverage

@github-actions
Copy link

@slab-ci cpu_fast_test

@github-actions
Copy link

@slab-ci cpu_fast_test

@soonum soonum marked this pull request as draft September 15, 2023 13:21
@soonum
Copy link
Contributor Author

soonum commented Sep 19, 2023

As discussed with @IceTDrinker, we should assume that the linter is installed and if not print the link to the release page.
That way we don't install software in non-desired location and we don't have to worry about cross-platform installation.

@github-actions
Copy link

@slab-ci cpu_fast_test

1 similar comment
@github-actions
Copy link

@slab-ci cpu_fast_test

@github-actions
Copy link

@slab-ci cpu_fast_test

@soonum soonum marked this pull request as ready for review September 19, 2023 10:52
IceTDrinker
IceTDrinker reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small nitpicks otherwise looks good !

Don't forget to make a small announcement to the team so that people can install linelint on their systems (and tell them that make conformance is awesome) :)

.github/workflows/cargo_build.yml Show resolved Hide resolved
.github/workflows/cargo_build.yml Outdated Show resolved Hide resolved
ci/lattice_estimator.sage Outdated Show resolved Hide resolved
@github-actions
Copy link

@slab-ci cpu_fast_test

IceTDrinker
IceTDrinker approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@github-actions
Copy link

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@soonum soonum merged commit 53da809 into main Sep 20, 2023
20 checks passed
@soonum soonum deleted the dt/ci/newline_linter branch September 20, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker approved these changes

Assignees

@soonum soonum

Labels
approved ci cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soonum @IceTDrinker