fix(integer): is_neg/sub/add possible #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slab-ci cpu_fast_test |
tmontaigu
force-pushed
the
fix-is-possible
branch
from
a99f3fc
to
651f5dc
Compare
|
@slab-ci cpu_fast_test |
|
@slab-ci cpu_integer_test |
tmontaigu
force-pushed
the
fix-is-possible
branch
from
651f5dc
to
9430a17
Compare
|
@slab-ci cpu_fast_test |
tmontaigu
force-pushed
the
fix-is-possible
branch
from
9430a17
to
9f12974
Compare
|
@slab-ci cpu_fast_test |
IceTDrinker
reviewed
Sep 25, 2023
IceTDrinker
reviewed
Sep 25, 2023
The way we did the is_neg/add/sub possible at the integer level was incorrect in two ways. 1) We simply called the is_neg/add/sub_possible from the shortint impl on each block as if the were independant. However that is not the case, and to the check did not reflect actual computation. 2) We checked that we did not go beyond max degree on each block, However, a more correct approach would be to check that adding the potential carry from preceding block would not exceeding the current block max capacity.
tmontaigu
force-pushed
the
fix-is-possible
branch
from
9f12974
to
4341b18
Compare
|
@slab-ci cpu_fast_test |
|
Pull Request has been approved 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we did the is_neg/add/sub possible at the integer level was incorrect in two ways.
We simply called the is_neg/add/sub_possible from
the shortint impl on each block as if the were independant.
However that is not the case, and to the check did not reflect
actual computation.
We checked that we did not go beyond max degree on each block,
However, a more correct approach would be to check that adding
the potential carry from preceding block would not exceeding the
current block max capacity.
Fixes asserts for is_sub_possible being triggered in #536