chore(hlapi): remove unused keychain_member from macro #587
Conversation
|
@slab-ci cpu_fast_test |
| assert_eq!( | ||
| cks.parameters().message_modulus().0, | ||
| 1 << 2, | ||
| "This API only supports integers with 2 bits per block (MessageModulus(16))", |
There was a problem hiding this comment.
MessageModulus(4) ? in that case you could use the debug format to avoid having to write it yourself :)
| assert_eq!( | ||
| cks.parameters().message_modulus().0, | ||
| 1 << 2, |
There was a problem hiding this comment.
any reason for that ? I thought we were ok for 1_1 ?
There was a problem hiding this comment.
No were not (and still are not) ok with 1_1, in the HLAPI number of blocks are statically fixed for each types assuming 2_2 parameters.
And we don't support all operations on 1_1 parameters
So first we should support all ops on 1_1 at the integer level then we can add suport for 1_1 params in HLAPI
There was a problem hiding this comment.
in the HLAPI number of blocks are statically fixed for each types assuming 2_2 parameters
that's surprising, does it mean 3_3 or 4_4 params would not work as expected ?
There was a problem hiding this comment.
ah ok I just saw it's an assert_eq
tmontaigu
force-pushed
the
tm/hlapi-quick-fix
branch
from
9c73ee0
to
5dc7d75
Compare
|
@slab-ci cpu_fast_test |
|
Pull Request has been approved 🎉 |
No description provided.