Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integer): add default signed_scalar div/rem/div_rem #596

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat(integer): add default signed_scalar div/rem/div_rem #596

merged 1 commit into from
Oct 2, 2023

Conversation

tmontaigu
Copy link
Contributor

Check-list:

  • Tests for the changes have been added (for bug fixes / features)

@cla-bot cla-bot bot added the cla-signed label Sep 28, 2023
@github-actions
Copy link

@slab-ci cpu_fast_test

@tmontaigu
Copy link
Contributor Author

@slab-ci cpu_fast_test

IceTDrinker
IceTDrinker reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from that small error in a docstring

@github-actions
Copy link

@slab-ci cpu_fast_test

@github-actions
Copy link

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@github-actions github-actions bot removed the approved label Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

@slab-ci cpu_fast_test

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@tmontaigu tmontaigu merged commit 082328c into main Oct 2, 2023
19 checks passed
@tmontaigu tmontaigu deleted the default-signed-div-rem branch October 2, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker Awaiting requested review from IceTDrinker

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmontaigu @IceTDrinker