feat(hlapi): tie scalar ops with corresponding clear type #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slab-ci cpu_fast_test |
tmontaigu
force-pushed
the
hlpi-refactor-scalar
branch
from
3e628f4
to
30332e4
Compare
|
@slab-ci cpu_fast_test |
Operations that used a scalar as right operand where generically implemented meaning a user could, for example, add a u32 to a FheUint8. Rust only allows operations between matching types, so we do the same thing. BREAKING CHANGE: This is a breaking change on the Rust API, but for the better I believe. On the C API it is not a breaking change as we already made that association as it was simpler to implement
tmontaigu
force-pushed
the
hlpi-refactor-scalar
branch
from
30332e4
to
7513d83
Compare
|
@slab-ci cpu_fast_test |
IceTDrinker
approved these changes
Oct 2, 2023
|
Pull Request has been approved 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operations that used a scalar as right operand where generically implemented meaning a user could, for example, add a u32 to a FheUint8.
Rust only allows operations between matching types, so we do the same thing.
BREAKING CHANGE: This is a braking change on the Rust API, but for the better I believe. On the C API it is not a breaking change as we already made that assocation as it was simpler to implement
Check-list: