Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): remove a copy in the external product #600

Merged
merged 1 commit into from
Oct 3, 2023
Merged

refactor(core): remove a copy in the external product #600

merged 1 commit into from
Oct 3, 2023

Conversation

IceTDrinker
Copy link
Member

PR content/description

  • add an fft backward primitive that can use the input fourier buffer as output as well
  • gains 0.6 ms on 2_2 m6i.metal

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

@slab-ci cpu_fast_test

@IceTDrinker
Copy link
Member Author

bench link https://github.com/zama-ai/tfhe-rs/actions/runs/6381679485

@IceTDrinker
refactor(core): remove a copy in the external product
9ae5de9 
- add an fft backward primitive that can use the input fourier buffer as
output as well
- gains 0.6 ms on 2_2 m6i.metal
@IceTDrinker IceTDrinker force-pushed the am/refactor/ext-prod-less-copy branch from 5edea3b to 9ae5de9 Compare October 2, 2023 15:14
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

@slab-ci cpu_fast_test

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@IceTDrinker IceTDrinker merged commit fad066a into main Oct 3, 2023
19 checks passed
@IceTDrinker IceTDrinker deleted the am/refactor/ext-prod-less-copy branch October 3, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmontaigu tmontaigu tmontaigu approved these changes

@sarah-ek sarah-ek Awaiting requested review from sarah-ek

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IceTDrinker @tmontaigu