[PDE-5065] cli(fix): Add shell: true as a default option for Window…

…s users when running spawn() command (#788) * add shell: true as an option for Windows * review suggestion
zapier · May 27, 2024 · 360feed · 360feed
1 parent 0ba70f9
commit 360feed
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packages/cli/src/utils/misc.js b/packages/cli/src/utils/misc.js
@@ -25,16 +25,19 @@ const isWindows = () => {
 
 // Run a bash command with a promise.
 const runCommand = (command, args, options) => {
-  if (isWindows()) {
-    command += '.cmd';
-  }
-
   if (_.get(global, ['argOpts', 'debug'])) {
     debug.enabled = true;
   }
 
   options = options || {};
 
+  if (isWindows()) {
+    command += '.cmd';
+
+    // See CVE-2024-27980
+    options.shell = true;
+  }
+
   debug('\n');
   debug(
     `Running ${colors.bold(