Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy-scripting-runner): [PDE-5515] Install aws-sdk v2 for legacy-scripting-runner #912

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

rnegron
Copy link
Member

@rnegron rnegron commented Nov 4, 2024

Node.js v18 in Lambda removed implicit aws-sdk v2 support, see: https://aws.amazon.com/blogs/compute/node-js-18-x-runtime-now-available-in-aws-lambda/

Certain apps that depend on legacy-scripting-runner use the AWS object, so a safe solution is to explicitly install and require aws-sdk for this package.

See Slack context: https://zapier.slack.com/archives/C04QN139NV6/p1730737223650609?thread_ts=1730491575.645539&cid=C04QN139NV6

@rnegron rnegron requested a review from a team as a code owner November 4, 2024 16:29
@rnegron rnegron changed the title fix(llegacy-scripting-runner): [PDE-5515] Install aws-sdk v2 for legacy-scripting-runner fix(legacy-scripting-runner): [PDE-5515] Install aws-sdk v2 for legacy-scripting-runner Nov 4, 2024
@rnegron rnegron merged commit a35081b into main Nov 6, 2024
14 checks passed
@rnegron rnegron deleted the PDE-5515 branch November 6, 2024 13:07
rnegron added a commit that referenced this pull request Nov 14, 2024
…or legacy-scripting-runner (#912)"

This reverts commit a35081b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants