Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vipps Checkout #46

Open
wants to merge 21 commits into
base: 2.x
Choose a base branch
from
Open

Vipps Checkout #46

wants to merge 21 commits into from

Conversation

ivanruzak
Copy link

No description provided.

@ivanruzak ivanruzak marked this pull request as ready for review August 29, 2022 11:51
src/Api/Checkout.php Outdated Show resolved Hide resolved
src/Api/Checkout.php Outdated Show resolved Hide resolved
@ivanruzak ivanruzak requested a review from zaporylie August 30, 2022 09:09
@zaporylie
Copy link
Owner

Please fix code style errors once you get time.

Copy link
Owner

@zaporylie zaporylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝🏻

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #46 (4604836) into 2.x (eddf28e) will decrease coverage by 17.57%.
The diff coverage is 0.00%.

❗ Current head 4604836 differs from pull request most recent head 8445d4b. Consider uploading reports for the commit 8445d4b to get more accurate results

@@              Coverage Diff              @@
##                2.x      #46       +/-   ##
=============================================
- Coverage     60.39%   42.82%   -17.58%     
- Complexity      440      561      +121     
=============================================
  Files            80      101       +21     
  Lines          1457     2055      +598     
=============================================
  Hits            880      880               
- Misses          577     1175      +598     
Flag Coverage Δ
unittests 42.82% <0.00%> (-17.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Api/Checkout.php 0.00% <0.00%> (ø)
src/Model/Checkout/AmountBase.php 0.00% <0.00%> (ø)
src/Model/Checkout/BillingDetails.php 0.00% <0.00%> (ø)
src/Model/Checkout/CustomerDetailsBase.php 0.00% <0.00%> (ø)
src/Model/Checkout/Logistics.php 0.00% <0.00%> (ø)
src/Model/Checkout/LogisticsOption.php 0.00% <0.00%> (ø)
src/Model/Checkout/MerchantInfo.php 0.00% <0.00%> (ø)
src/Model/Checkout/PaymentDetails.php 0.00% <0.00%> (ø)
src/Model/Checkout/PaymentTransaction.php 0.00% <0.00%> (ø)
src/Model/Checkout/PrefillCustomer.php 0.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ivanruzak
Copy link
Author

@zaporylie all tests have been passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants