-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue support): support Volar 1.7.0+ #140
Conversation
drop support for previous version
@maIIady It turns out it was pretty easy to fix, I pushed working version, but of course versions prior 1.7.0 are no longer supported Changing settings now require server reload, watcher doesnt work for some reason. Another thing that is not supported is syntax server features, you can try to add workaround: const syntaticLanguageService = typescriptService.provide['typescript/syntacticLanguageService']({
version: 0,
getText() {
return ''
},
uri: undefined
}) |
I didn't get at all how to implement your workaround and how it should work :( I checked that it works and updated the related setting implementation but I won't be able to provide support for mentioned features myself |
Not a big deal, we can do it later though we can merge now |
Will release tomorrow. For now you can install & use extension from latest run of this pr: https://github.com/zardoy/typescript-vscode-plugins/actions/runs/5525801559 |
Since 1.7+ we can't access ts from plugin context
PR Related changelog refs:
Currently I'm really struggling with how to make plugin work again in the latest version. Definitely gonna investigate soon, but any help is very appreciated