Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactoring): add/from destructure improvements #182

Merged
merged 9 commits into from
Nov 8, 2023

Conversation

Ilanaya
Copy link
Collaborator

@Ilanaya Ilanaya commented Nov 1, 2023

No description provided.

@Ilanaya Ilanaya self-assigned this Nov 1, 2023
@zardoy zardoy changed the title feat(code actions): add/from destructure improvements feat(refactoring): add/from destructure improvements Nov 1, 2023
@zardoy
Copy link
Owner

zardoy commented Nov 2, 2023

since we also do support vue maybe it would be useful to detect cases when we need to wrap the generated result of destruct refactoring with toRefs?

@zardoy
Copy link
Owner

zardoy commented Nov 4, 2023

This is getting really good!

@zardoy zardoy marked this pull request as ready for review November 4, 2023 00:26
@zardoy
Copy link
Owner

zardoy commented Nov 8, 2023

@Ilanaya i think it's good merge. Tests and handles cases are not bad and want to finally release this so badly :)

@Ilanaya
Copy link
Collaborator Author

Ilanaya commented Nov 8, 2023

Agree, I'll complete this feature (add 'this' support and vue refs) when I'll have more spare time(probably this weekend), so if you want you can release it now.

@zardoy
Copy link
Owner

zardoy commented Nov 8, 2023

TYSM!

@zardoy zardoy merged commit 00d3fee into develop Nov 8, 2023
1 check passed
@zardoy zardoy deleted the 167-destructure-fixes branch November 8, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants