Refactor compose e2e test to not depend on CLI output #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
phillebaba
force-pushed
the
refactor/compose-test
branch
from
98eeaaf
to
f4afe74
Compare
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
refactor/compose-test
branch
from
f4afe74
to
27db1e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes any use of CLI output for compose e2e tests. This enables the refactoring of log output without breaking the e2e tests.
Related Issue
Relates to #2576
Relates to #2969
Checklist before merging