fix: add check during image discovery to make sure images are valid

[a1994sc]

Description

When using zarf to discover images with the Ironbank chart kyverno-policies, the restrict-image-registries policy, (simple version included in tests), has an entry of:

• registry.dso.mil/*

This is a false positive and cases cosign looks up to fail as that is not a valid image.

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[netlify]

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	f811a85
🔍 Latest deploy log	https://app.netlify.com/sites/zarf-docs/deploys/6733c4caa3301a0008950240

[netlify]

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	0b2f368
🔍 Latest deploy log	https://app.netlify.com/sites/zarf-docs/deploys/67b21f3682261b0008eac692

[a1994sc]

Related to #3253

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ
src/pkg/packager/prepare.go	53.84% <100.00%> (+0.38%)	⬆️
src/pkg/packager/regex.go	100.00% <100.00%> (ø)

[a1994sc]

Any reason those two test are stuck?

[brandtkeller]

Any reason those two test are stuck?

GitHub reports "unexpected error" - so I'm going to give those a retry real quick.

[a1994sc]

Any reason those two test are stuck?

GitHub reports "unexpected error" - so I'm going to give those a retry real quick.

Ah, thank you very much!!

[brandtkeller]

This definitely improves the baseline. I'll let another maintainer weigh-in if there is any patterns or constraints we want to follow with regards to the regex logic - otherwise LGTM.

[a1994sc]

Thanks!! I was a little worried that because you all are migrating to package2 it might have needed to be put on hold. Though very happy to help an awesome project!

[mkcp]

LGTM. Good test case and defense for the logic. Matching the license and incl. attribution makes accepting this easy. Nice job

[a1994sc]

I would be happy to help with the effort to port over to the package2 implementation, whenever that works starts

[a1994sc]

Thanks Team!!