Actually use emptydir mount when persistence is disabled #3241
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
In zarf-dev#2124, an emptydir was mounted when `persistence.enabled: false` is set. However, this is not enough to make registry work: it crashloops as in issue zarf-dev#1998. This is fixed by setting the env variable specifying storage config even if persistence is disabled. Signed-off-by: Adam Michalik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #2124, an emptydir was mounted when
persistence.enabled: falseis set. However, this is not enough to make registry work: it crashloops as in issue #1998:This is fixed by setting the env variable specifying storage config even if persistence is disabled:
Related Issue
Fixes #1998
Checklist before merging