Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: package publish #3495

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft

refactor: package publish #3495

wants to merge 42 commits into from

Conversation

AustinAbro321
Copy link
Contributor

Description

refactor: package publish

Related Issue

Fixes #

Relates to #

Checklist before merging

@AustinAbro321
WIP
e540b13 
Signed-off-by: Austin Abro <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit ef90976
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67be3618da68f10008ef0b75

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.06897% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/publish.go 66.03% 12 Missing and 6 partials ⚠️
src/internal/packager2/layout/package.go 0.00% 2 Missing ⚠️
src/pkg/zoci/push.go 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/package.go 38.74% <0.00%> (-0.29%) ⬇️
src/pkg/zoci/push.go 59.55% <33.33%> (+59.55%) ⬆️
src/internal/packager2/publish.go 66.03% <66.03%> (ø)

... and 2 files with indirect coverage changes

mkcp and others added 19 commits February 14, 2025 09:07
@mkcp
Update src/internal/packager2/publish.go
faf7b26 
Add github tag to comment

Signed-off-by: Kit Patella <[email protected]>
@brandtkeller
feat(publish): create vars
396b2cb
@AustinAbro321
WIP
1f93ed2 
Signed-off-by: Austin Abro <[email protected]>
@mkcp
generate a working ref in p2 publish.go and publish_test.go
f6ed126 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
match remote pkg and expectedPkg and add future test case
76562b5 
Signed-off-by: Kit Patella <[email protected]>
@brandtkeller
feat(publish): determine skeleton package
d9e9a37 
Signed-off-by: Brandt Keller <[email protected]>
@brandtkeller
feat(publish): WIP standard package testing
b839172
@AustinAbro321
WIP
575bb30 
Signed-off-by: Austin Abro <[email protected]>
@brandtkeller
feat: adding package publish logic
81a518b
@mkcp
Fix PublishSkeleton, continue iterating on publish package
40f9515 
Signed-off-by: Kit Patella <[email protected]>
@brandtkeller
fix: update logic and tests
9beca6e 
Signed-off-by: Brandt Keller <[email protected]>
@brandtkeller
feat(publish): swap to layout2 from zoci, fix test
e909338 
Signed-off-by: Brandt Keller <[email protected]>
@mkcp
refactor publish and clean up code. plus comments and logging
b83d93d 
Signed-off-by: Kit Patella <[email protected]>
@mkcp
migrate required args to func signature
dd3b0c1 
Signed-off-by: Kit Patella <[email protected]>
@AustinAbro321
pass architecture into pull oci
c45679a 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
caps!
afb3a40 
Signed-off-by: Austin Abro <[email protected]>
@mkcp
compare layout.Pkg of expected and actual non-skeleton published pack…
074a506 
…ages

Signed-off-by: Kit Patella <[email protected]>
@AustinAbro321
better logs & testing logs
558b043 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
cleanup test resources
079dbfd 
Signed-off-by: Austin Abro <[email protected]>
mkcp and others added 15 commits February 21, 2025 11:55
@mkcp
migrate skeleton publish behavior to packager2.PublishSkeleton. updat…
ffe31bc 
…e tests

Signed-off-by: Kit Patella <[email protected]>
@mkcp
make top-level tests parallel, ignore cases for now
765d2e2 
Signed-off-by: Kit Patella <[email protected]>
@AustinAbro321
fix shasum
7a3296c 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
separate opts
b77b418 
Signed-off-by: Austin Abro <[email protected]>
@brandtkeller
fix(skeleton): publish skeleton skip signature validation
052b5b6 
Signed-off-by: Brandt Keller <[email protected]>
@mkcp
sketch out the oci to oci flow
ff3c2aa 
Signed-off-by: Kit Patella <[email protected]>
@AustinAbro321
start on publish
fdff950 
Signed-off-by: Austin Abro <[email protected]>
@brandtkeller
feat: trim src and test update
87338f1 
Signed-off-by: Brandt Keller <[email protected]>
@mkcp
fix arm bug for publish copy and debug timeout on zoci.CopyPackage
9eabc82 
Signed-off-by: Kit Patella <[email protected]>
@AustinAbro321
publish to publish test working
0e42ca4 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
package publish test better
64e3e78 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
fix test add concurrency
a613481 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
try sha
650192d 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
try sha
3b85a03 
Signed-off-by: Austin Abro <[email protected]>
@brandtkeller
feat: add test for sha
ef90976 
Signed-off-by: Brandt Keller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcp mkcp mkcp left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AustinAbro321 @mkcp @brandtkeller