Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest arrays use arrayv3metadata #429
base: zarr-python-3.0
Are you sure you want to change the base?
Manifest arrays use arrayv3metadata #429
Changes from 10 commits
2a01bfa
17fd547
e5666ab
5a8cc4c
4c0b616
ac2f787
5503c60
1272051
1f36755
7098803
ce2284c
c9853d5
209dae3
e7205ef
d65e457
190c20f
47f5ddd
5d15608
908bc52
4a8bfdd
d05cec3
ff23eeb
8560f2d
97d0a71
669ce52
b794dab
825142d
6684125
5e82de4
f57b48d
b811959
8c5139b
eb2a86c
15ac7a7
5359762
c808351
bd50167
ed97704
a3c190e
95886b9
a0f72b2
aad511f
b357b04
08e877a
f040459
495d660
a262f0b
bcd68a0
f0ce778
0518488
0712979
c40915d
cdaca53
2415e07
9366d69
d590cfc
6394207
ea9fd56
0ee2b48
86d1de5
fe8305f
0f5b32d
97bc7cd
b5a1dc6
12c6260
4b555b6
c245b0a
23ac776
402af7f
3e2e8ec
92293a6
eccc215
8fa72b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to specify attrs here? I feel like we want neither
dimension_names
norattrs
, because in virtualizarr those both are stored in the xarray objects instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dimension_names
is a required argument (even though it can beNone
, I'm not sure whyNone
is not set as a default in the init method. I have removed setting attributes from this reader in 86d1de5Should we request upstream for a default of None to be allowed in the init method of ArrayV3Metadata?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this comment because I think the reference is from a previous version of zarr-python - @sharkinsspatial do you know if we can and should include an updated link?