Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start applying ruff rules to notebooks (ruff 0.6+) #2115

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Start applying ruff rules to notebooks (ruff 0.6+) #2115

wants to merge 11 commits into from

Commits on Nov 5, 2024

  1. Apply ruff/Pyflakes rule F401 to notebooks 

    F401 imported but unused
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5edfe6c View commit details
    Browse the repository at this point in the history

  2. Apply ruff/Pyflakes rule F811 to notebooks 

    F811 Redefinition of unused
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    cb398b0 View commit details
    Browse the repository at this point in the history

  3. Apply ruff/pycodestyle rule W291 rule to notebooks 

    W291 Trailing whitespace
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    396a165 View commit details
    Browse the repository at this point in the history

  4. Appply ruff/pycodestyle rule W293 to notebooks 

    W293 Blank line contains whitespace
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    12f6df8 View commit details
    Browse the repository at this point in the history

  5. Apply ruff/isort rule I001 to notebooks 

    I001 Import block is un-sorted or un-formatted
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    04ee419 View commit details
    Browse the repository at this point in the history

  6. Apply ruff/pyupgrde rule UP031 to notebooks 

    UP031 Use format specifiers instead of percent format
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bd2d489 View commit details
    Browse the repository at this point in the history

  7. Apply ruff/pyupgrade rule UP032 to notebooks 

    UP032 Use f-string instead of `format` call
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    43606ce View commit details
    Browse the repository at this point in the history

  8. Apply ruff/pyupgrade rule UP033 to notebooks 

    UP033 Use `@functools.cache` instead of `@functools.lru_cache(maxsize=None)`
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5141321 View commit details
    Browse the repository at this point in the history

  9. Apply ruff rule RUF010 to notebooks 

    RUF010 Use explicit conversion flag
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f10e623 View commit details
    Browse the repository at this point in the history

  10. Apply ruff/pycodestyle rule E402 to notebooks 

    E402 Module level import not at top of cell
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c3c3a99 View commit details
    Browse the repository at this point in the history

  11. Remove notebooks 

    Many of them are referencing data that we don't have access to.
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a723011 View commit details
    Browse the repository at this point in the history