Define default classes while subclassing #3843
Draft
+72
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this technically a breaking change or can it be defined as a bugfix? Some users might be reliant on the existing behavior |
|
@ghbm-itk That's a good question. At the moment even the pytests are broken. I'll try to fix them first. Then we should evaluate how exactly the behavior changed and if we consider it a bug fix or a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
default_classes,default_styleanddefault_propsarguments forElement.__init_subclass__so that defaults like "nicegui-*" classes can be defined while subclassing. This way they can be removed by the user calling something likeui.link.default_classes(replace='text-red-500'), solving issue #3826.