Skip to content

Commit

Permalink
zfsbootmenu-core: disable zfs_dmu_offset_next_sync for R/W pools
Browse files Browse the repository at this point in the history
this currently appears to mostly or fully mitigate the silent corruption
bug that was originally thought to be caused by block cloning. Keeping
bclone disabled for now as it is a common avenue for triggering the bug,
despite not being the root cause.

see openzfs/zfs#15526
  • Loading branch information
classabbyamp authored and zdykstra committed Nov 24, 2023
1 parent d566a1d commit 45cbf0f
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions zfsbootmenu/lib/zfsbootmenu-core.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1438,6 +1438,11 @@ set_rw_pool() {
echo 0 > /sys/module/zfs/parameters/zfs_bclone_enabled
fi

if [ -w /sys/module/zfs/parameters/zfs_dmu_offset_next_sync ] ; then
zdebug "disabling zfs_dmu_offset_next_sync on writeable pools"
echo 0 > /sys/module/zfs/parameters/zfs_dmu_offset_next_sync
fi

# If force_export is set, skip evaluating if the pool is already read-write
# shellcheck disable=SC2154
[ -n "${force_export}" ] || ! is_writable "${pool}" || return 0
Expand Down

0 comments on commit 45cbf0f

Please sign in to comment.