Cleaner logic to handle types of extends and implements clauses and f…

…ixed `getTypeOfExtendsImplements` (opprop#134)
zcai1 · Jan 7, 2022 · 9e44da6 · 9e44da6
1 parent 8339331
commit 9e44da6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/docs/manual/contributors.tex b/docs/manual/contributors.tex
@@ -89,6 +89,7 @@
 Paul Vines,
 Paulo Barros,
 Philip Lai,
+Piyush Jha,
 Prionti Nasir,
 Priti Chattopadhyay,
 Rashmi Mudduluru,

diff --git a/framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java b/framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
@@ -526,25 +526,15 @@ public void processClassTree(ClassTree classTree) {
 
         Tree ext = classTree.getExtendsClause();
         if (ext != null) {
-            for (AnnotatedDeclaredType superType : classType.directSupertypes()) {
-                if (superType.getUnderlyingType().asElement().getKind().isClass()) {
-                    validateType(ext, superType);
-                    break;
-                }
-            }
+            AnnotatedTypeMirror superClass = atypeFactory.getTypeOfExtendsImplements(ext);
+            validateType(ext, superClass);
         }
 
         List<? extends Tree> impls = classTree.getImplementsClause();
         if (impls != null) {
             for (Tree im : impls) {
-                for (AnnotatedDeclaredType superType : classType.directSupertypes()) {
-                    if (superType.getUnderlyingType().asElement().getKind().isInterface()
-                            && types.isSameType(
-                                    superType.getUnderlyingType(), TreeUtils.typeOf(im))) {
-                        validateType(im, superType);
-                        break;
-                    }
-                }
+                AnnotatedTypeMirror superInterface = atypeFactory.getTypeOfExtendsImplements(im);
+                validateType(im, superInterface);
             }
         }
 

diff --git a/framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java b/framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java
@@ -1386,6 +1386,7 @@ public AnnotatedTypeMirror getTypeOfExtendsImplements(Tree clause) {
         AnnotatedTypeMirror fromTypeTree = fromTypeTree(clause);
         Set<AnnotationMirror> bound = getTypeDeclarationBounds(fromTypeTree.getUnderlyingType());
         fromTypeTree.addMissingAnnotations(bound);
+        addComputedTypeAnnotations(clause, fromTypeTree);
         return fromTypeTree;
     }