Bump MSRV to 1.77 #1582
Merged
Bump MSRV to 1.77 #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
- Coverage 61.88% 55.94% -5.94%
==========================================
Files 149 149
Lines 18946 18728 -218
==========================================
- Hits 11724 10477 -1247
- Misses 7222 8251 +1029 ☔ View full report in Codecov by Sentry. |
nuttycom
approved these changes
Oct 23, 2024
| @@ -2020,7 +2020,21 @@ pub(crate) fn block_fully_scanned<P: consensus::Parameters>( | |||
| // | |||
| // The fully-scanned height is therefore the last height that falls within the first range in | |||
| // the scan queue with priority "Scanned". | |||
| // SQL query problems. | |||
| let calc_fully_scanned_height = |row: &rusqlite::Row| { | |||
There was a problem hiding this comment.
This change is fine, but for my education what in the MSRV change prompted it?
There was a problem hiding this comment.
The new lint is "in a match scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a let".
https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.