-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature flag updates #116
Feature flag updates #116
Conversation
This matches the `orchard` crate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change requested.
@@ -1065,7 +1065,7 @@ impl<V> Bundle<InProgress<Proven, PartiallyAuthorized>, V> { | |||
} | |||
|
|||
#[cfg(any(test, feature = "test-dependencies"))] | |||
pub mod testing { | |||
pub(crate) mod testing { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent of the test-dependencies
feature is that by enabling it, the testing
module is made available to downstream crates. So I don't think this is the right change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing public in this module. In fact, there's an #[allow(dead_code)]
on the strategy in this module. If that is made public at some point, then this can be reverted, but as-is this is an empty module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd argue that maybe it's better to make arb_bundle
public, and remove the allow
, but I guess this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
No description provided.