init CI and some fixes #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix dockerfile and vladdoster config, setup CI
This reverts commit 0712fa0.
3x8 fix ci
* remove caching * redo a pipeline * add matrix * remove fail-fast * rename a job Authored-by: tripleight <Denis>
vladdoster
requested changes
Jun 4, 2022
| lbin'!**/tree' Old-Man-Programmer/tree \ | ||
| lbin'!**/zsd' $ZI_REPO/zshelldoc | ||
| lbin'!**/tree*' Old-Man-Programmer/tree \ | ||
| lbin'!**/zsd*' $ZI_REPO/zshelldoc |
There was a problem hiding this comment.
not sure if you've tried this, but this glob actually breaks zsd and tree.
Suggested change
| lbin'!**/zsd*' $ZI_REPO/zshelldoc | |
| lbin'!**/bin/zsd' $ZI_REPO/zshelldoc |
| @@ -107,8 +107,8 @@ zi as'command' light-mode for \ | |||
| pick'zunit' atclone'./build.zsh' @zunit-zsh/zunit | |||
| #=== COMPILED PROGRAMS ================================ | |||
| zi lucid make'PREFIX=$PWD install' nocompile for \ | |||
| lbin'!**/tree' Old-Man-Programmer/tree \ | |||
| lbin'!**/zsd' $ZI_REPO/zshelldoc | |||
| lbin'!**/tree*' Old-Man-Programmer/tree \ | |||
There was a problem hiding this comment.
Suggested change
| lbin'!**/tree*' Old-Man-Programmer/tree \ | |
| lbin'!**/bin/tree' Old-Man-Programmer/tree \ |
| @@ -97,7 +97,7 @@ zi from'gh-r' lbin'!' nocompile for \ | |||
| lbin'!**/rg' @BurntSushi/ripgrep \ | |||
| lbin atinit" | |||
| alias ll='exa -al'; | |||
| alias l='exa -blF'; | |||
| @@ -27,7 +27,8 @@ RUN sh -c "$(curl -fsSL https://raw.githubusercontent.com/zdharma/zinit/master/d | |||
|
|
|||
| # Copy configs into home directory | |||
| ARG FOLDER | |||
| COPY --chown=user "${FOLDER}" /home/user | |||
| ENV XDG_DATA_HOME /home/user/.local/share | |||
| COPY --chown=user ./${FOLDER} /home/user | |||
There was a problem hiding this comment.
Suggested change
| COPY --chown=user ./${FOLDER} /home/user | |
| COPY --chown=user ./"$FOLDER" /home/user |
| paths: | ||
| - .github/workflows/test_configs.yml | ||
| - Dockerfile | ||
| - vladdoster/.zshrc |
There was a problem hiding this comment.
Might as well just normalize the configuration file to be zshrc or something. I'll leave that to your discretion. So the following suggestions work
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, it runs on the changes of files that I've tested and fixed.
When more zsh configs will be fixed, this file should be copied for every config in the repo, or something like https://github.com/dorny/paths-filter might be used to be DRY.
Didn't use buildx because it can't use the cache right now cc docker/build-push-action#558
cc @vladdoster