Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add command before instances of git that didn't have it #643

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix: add command before instances of git that didn't have it #643

merged 2 commits into from
Mar 19, 2024

Conversation

kiliantyler
Copy link
Contributor

@kiliantyler kiliantyler commented Mar 15, 2024 •
edited by vladdoster
Loading

Description

Motivation and Context

If git is aliased to something that doesn't work identically (e.g. bit) then zinit update <plugin> can fail, as well as zinit version

Most other instances of git already use command git, there was just a few missing.

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@vladdoster
Copy link
Member

Did you check zinit{,-{additional,install,side}}.zsh or just zinit-autoload.zsh?

@vladdoster
Copy link
Member

#644 fixes failing test

vladdoster
vladdoster approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@vladdoster vladdoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladdoster vladdoster merged commit 7094330 into zdharma-continuum:main Mar 19, 2024
4 checks passed
@vladdoster
Copy link
Member

@kiliantyler,

Thank you for taking the time to improve Zinit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladdoster vladdoster vladdoster approved these changes

@alichtman alichtman Awaiting requested review from alichtman alichtman is a code owner

@pschmitt pschmitt Awaiting requested review from pschmitt pschmitt is a code owner

Assignees
No one assigned
Labels
fix release zinit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiliantyler @vladdoster