ZEA-4341: Fix Svelte containerized start command (#391)

zeabur · Nov 30, 2024 · cc96ee4 · cc96ee4
2 parents 097df78 + 658380e
commit cc96ee4
Show file tree

Hide file tree

Showing 4 changed files with 66 additions and 0 deletions.
diff --git a/internal/nodejs/plan.go b/internal/nodejs/plan.go
@@ -804,6 +804,12 @@ func GetStartCmd(ctx *nodePlanContext) string {
 			} else {
 				startCmd = "node " + entry
 			}
+		case framework == types.NodeProjectFrameworkSvelte:
+			if ctx.Bun {
+				startCmd = "bun build/index.js"
+			} else {
+				startCmd = "node build/index.js"
+			}
 		case types.IsNitroBasedFramework(string(framework)):
 			if ctx.Bun {
 				startCmd = "HOST=0.0.0.0 bun .output/server/index.mjs"

diff --git a/internal/nodejs/plan_test.go b/internal/nodejs/plan_test.go
@@ -562,6 +562,49 @@ func TestGetStartCommand_Entry(t *testing.T) {
 		assert.Equal(t, "", startCmd)
 	})
 
+	t.Run("containerized svelte", func(t *testing.T) {
+		t.Parallel()
+
+		fs := afero.NewMemMapFs()
+		_ = afero.WriteFile(fs, "package.json", []byte(`{
+			"devDependencies": {
+				"svelte": "*"
+			}
+		}`), 0o644)
+
+		ctx := &nodePlanContext{
+			Src:        fs,
+			Config:     plan.NewProjectConfigurationFromFs(fs, ""),
+			Framework:  optional.Some(types.NodeProjectFrameworkSvelte),
+			Serverless: optional.Some(false),
+		}
+
+		startCmd := GetStartCmd(ctx)
+		assert.Equal(t, "node build/index.js", startCmd)
+	})
+
+	t.Run("containerized svelte with bun", func(t *testing.T) {
+		t.Parallel()
+
+		fs := afero.NewMemMapFs()
+		_ = afero.WriteFile(fs, "package.json", []byte(`{
+			"devDependencies": {
+				"svelte": "*"
+			}
+		}`), 0o644)
+
+		ctx := &nodePlanContext{
+			Src:        fs,
+			Config:     plan.NewProjectConfigurationFromFs(fs, ""),
+			Framework:  optional.Some(types.NodeProjectFrameworkSvelte),
+			Serverless: optional.Some(false),
+			Bun:        true,
+		}
+
+		startCmd := GetStartCmd(ctx)
+		assert.Equal(t, "bun build/index.js", startCmd)
+	})
+
 	for _, framework := range types.NitroBasedFrameworks {
 		t.Run("nitro-"+string(framework), func(t *testing.T) {
 			t.Run("nodejs", func(t *testing.T) {

diff --git a/tests/real_project_test.go b/tests/real_project_test.go
@@ -269,6 +269,11 @@ var projects = []struct {
 		owner: "zeabur",
 		repo:  "vite-vanilla-template",
 	},
+	{
+		name:  "nodejs-sveltekit-v2",
+		owner: "zeabur",
+		repo:  "sveltekit-v2-template",
+	},
 	{
 		name: "nodejs-a-lot-of-dependencies",
 		dir:  "nodejs-a-lot-of-dependencies",

diff --git a/tests/snapshots/nodejs-sveltekit-v2.txt b/tests/snapshots/nodejs-sveltekit-v2.txt
@@ -0,0 +1,12 @@
+PlanType: nodejs
+
+Meta:
+  appDir: ""
+  buildCmd: "npm run build"
+  bun: "false"
+  bunVersion: "latest"
+  framework: "svelte"
+  installCmd: "COPY . .\nRUN npm install"
+  nodeVersion: "20"
+  packageManager: "npm"
+  startCmd: "node build/index.js"