#155: reverted workaround for iOS devices with dashes inside udid

zebrunner · Aug 29, 2023 · 0127973 · 0127973
1 parent b9bacd1
commit 0127973
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/lib/units/ios-device/plugins/install.js b/lib/units/ios-device/plugins/install.js
@@ -28,9 +28,6 @@ function execShellCommand(cmd) {
 }
 
 const installApp = (udid, filepath, id, isSimulator) => {
-    // #565 unable to do go-ios actions vs iOS with dashes in udid
-    udid = udid.replace("-", "")
-
     const simulatorCommands = [
         `cd ${filepath} && unzip * && xcrun simctl install ${udid} *.app`,
     ];
@@ -54,9 +51,6 @@ const installApp = (udid, filepath, id, isSimulator) => {
 }
 
 const launchApp = (udid, bundleId, isSimulator) => {
-    // #565 unable to do go-ios actions vs iOS with dashes in udid
-    udid = udid.replace("-", "")
-
     const simulatorCommands = [
         `xcrun simctl launch ${udid} ${bundleId}`,
     ];

diff --git a/lib/units/ios-device/plugins/reboot.js b/lib/units/ios-device/plugins/reboot.js
@@ -13,7 +13,7 @@ module.exports = syrup.serial()
 
     router.on(wire.RebootMessage, (channel) => {
         const reply = wireutil.reply(options.serial)
-        let udid = options.serial.replace("-", "")
+        let udid = options.serial
         exec(`ios reboot --udid=${udid}`) // this command that launches restart
          Promise.delay(5000)
          .then(() => {