This repository has been archived by the owner on May 12, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps zeebe-bpmn-moddle to v0.3.0 and integrates the new moddle extension.
The extension ensures that properties are allowed to be copied when replacing elements.
Eg. a
CallActivity
with acalledElement
attribute changed to a simpleTask
won't have itscalledElement
copied because it's not allowed onTask
elements, in accordance with the json schema.The schema itself is incomplete in its current version and doesn't specify for instance that a
<zeebe:TaskDefinition>
isn't allowed on anything else than aServiceTask
, implicitely allowing the property to be copied regardless of the parent element's type.See camunda/zeebe-bpmn-moddle#4 for context
Which issue does this PR address?
Closes #248
Acceptance Criteria
Definition of Done