Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Integrate zeebe-bpmn-moddle extension #274

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

azeghers
Copy link
Contributor

Description

Bumps zeebe-bpmn-moddle to v0.3.0 and integrates the new moddle extension.

The extension ensures that properties are allowed to be copied when replacing elements.
Eg. a CallActivity with a calledElement attribute changed to a simple Task won't have its calledElement copied because it's not allowed on Task elements, in accordance with the json schema.

The schema itself is incomplete in its current version and doesn't specify for instance that a <zeebe:TaskDefinition> isn't allowed on anything else than a ServiceTask, implicitely allowing the property to be copied regardless of the parent element's type.

See camunda/zeebe-bpmn-moddle#4 for context

Which issue does this PR address?

Closes #248

Acceptance Criteria

  • Corresponds to the concept
  • Corresponds to the design

Definition of Done

@MaxTru
Copy link
Contributor

MaxTru commented Nov 18, 2020

Works in principle ✔️

Tested with calledElement => works
Tested with Input Output Parameters => kind of works, (Inputs and Outputs are removed), but the surrounding IoMapping element remains present. (ie. this is what a task looks likes after it was morphed from a ServiceTask which had Input and Output mappings:

    <bpmn:task id="Activity_117rfe9" name="asdf">
      <bpmn:extensionElements>
        <zeebe:ioMapping />
      </bpmn:extensionElements>
    </bpmn:task>

We should get this "works 50%" state resolved. Therefore I will directly create an Issue in zeebe-bpmn-moddle and propose to merge this after we have zeebe-bpmn-moddle fixed.

@MaxTru
Copy link
Contributor

MaxTru commented Nov 18, 2020

See camunda/zeebe-bpmn-moddle#5

Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use zeebe-bpmn-moddle 0.4.0 (see #274 (comment))

-Bump zeebe-bpmn-moddle to v0.4.0
Closes #248
@MaxTru MaxTru force-pushed the 248-integrate-zeebe-moddle-extension branch from 3216813 to 6ee3281 Compare November 18, 2020 09:42
@azeghers azeghers requested a review from MaxTru November 18, 2020 09:59
Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@merge-me merge-me bot merged commit 9249843 into master Nov 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the 248-integrate-zeebe-moddle-extension branch November 18, 2020 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants