Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up upstream CAF patch for flow::from_steps #382

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

Neverlord
Copy link
Member

I've hit this recently with Zeek, so I've backported a CAF patch. After the broker::variant work, we should start following CAF releases again to receive patches like this automatically.

Copy link
Contributor

@awelzel awelzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be interesting to know if / how this would manifest in Zeek, but I guess we do not quite know?

Should this be backported included into the next 6.1/6.0 patch release?

@Neverlord
Copy link
Member Author

It would be interesting to know if / how this would manifest in Zeek, but I guess we do not quite know?

If it manifests, it's a segfault (dereferencing a null pointer). Reproducing is tricky, though. Only happens for me with the variant branch, but I didn't dig into why it's not happening otherwise.

Should this be backported included into the next 6.1/6.0 patch release?

I suppose there's no reason not to. 🙂

@Neverlord Neverlord merged commit 767b19d into master Dec 4, 2023
24 checks passed
@Neverlord Neverlord deleted the topic/neverlord/caf-fix-backport branch December 4, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants