Fixes for all of the GitHub workflows #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub's action runner complains that we're still trying to use macOS 11 and is killing the builds. This requires some tinkering with the brew packages that are installed, but don't like to update cleanly (python and php specifically).
awelzel
approved these changes
Dec 1, 2023
.github/workflows/main.yml
Outdated
| with: | ||
| submodules: recursive | ||
|
|
||
| - name: Set up ccache | ||
| uses: hendrikmuhs/[email protected].2 | ||
| uses: hendrikmuhs/[email protected].10 |
There was a problem hiding this comment.
In theory one should be able to use @v1.2 or even @v1 so that the next patch or minor version is picked up automatically.
Unfortunately, seems the v1 and v1.2 tags of the ccache-action are still pointing at v1.2.9 and have not been moved to v1.2.10.
cc @hendrikmuhs - was that an oversight?
There was a problem hiding this comment.
yes, I forgot to slice the tag.
However, I actually think it is best practice to use a fixed tag/commit hash and use e.g. dependabot to keep it uptodate.
This fixes, among other things, build failures on macOS due to sprintf being fully deprecated in XCode 14.
This fixes the build on Windows failing to find zlib.
timwoj
force-pushed
the
topic/timw/workflow-fixes
branch
from
54433a7
to
cd5f443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.