-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ci workflow #28
Conversation
445eeae
to
a06b96d
Compare
fixes error: no member named 'numeric_limits' in namespace 'std'
@kturney Thanks for the PR. This looks great! My only ask is that we keep using the pinned version of Rust (aka the one from rust-toolchain) in CI. Otherwise, I believe CI may break (typically clippy) whenever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
back to your queue
Hi @ma2bd, thanks for the quick review! Are you wanting me to change every use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. It looks like that rustup show
actually installs the missing toolchain so we're good!
Summary
Revamps and fixes CI workflow.
Updates
rust-toolchain
to newerrust-toolchain.toml
rustup
included inubuntu-latest
to install the toolchain specified inrust-toolchain.toml
rust-analyzer
CI workflowapt-get
directlyPotential shortcomings
std::numeric_limits
to fix cpp tests, matching fix found here. I'm not sure if that is considered a breaking change.Misc
Warnings during tests indicate that [email protected] is no longer supported. We could use this opportunity to bump the minimum support versions of different supported runtimes.