Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you very much for this fantastic tool!!
I came across the use case to disable all checks for a file, more precisely the Helm
test-connnection
pod often found in Helm charts.This PR proposes skipping all checks for a file (
"kube-score/skip": "true"
) and checks ("kube-score/ignore": "*"
) using annotations. The root level annotation is checked on a per-file basis during parsing and tracked in theFileLocation
, which allows further differentiation between ignored checks and skipped files. Additionally, nested annotations are checked on a per-check basis similar to thekube-score/ignore
annotation.I greatly appreciate any feedback if this is something you agree could be useful.
Best, Roman
Note: Unfortunately, the tests do not pass due an unrelated issue that I am not familiar with, once this is resolved I plan to merge the fix back into this PR.