Run try-runtime also on RC tags #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1050 +/- ##
=======================================
Coverage 92.93% 92.93%
=======================================
Files 92 92
Lines 21589 21589
=======================================
Hits 20064 20064
Misses 1525 1525
Flags with carried forward coverage won't be shown. Click here to find out more. |
sea212
added
s:in-progress
sea212
added
s:review-needed
Chralt98
approved these changes
Jul 25, 2023
It's indicated at the file name: |
sea212
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adjusts the "tag" workflow to make it trigger on release candidate tags as well. It also renames the workflow to "try-runtime".
Currently the "tag" workflow is only executed when a final release tag (i.e.
v0.3.10) is pushed. Before the final release tag is created, release candidates are pushed (i.e.v0.3.10-rc1). The workflow should also execute on those release candidates, granting the maintainer the knowledge whether or not this precondition for a release is met.What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References