Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client auto update #1052

Merged
merged 11 commits into from
Jul 25, 2023
Merged

Client auto update #1052

merged 11 commits into from
Jul 25, 2023

Conversation

samuelarogbonlo
Copy link
Contributor

@samuelarogbonlo samuelarogbonlo commented Jul 24, 2023

What does it do?

Resolves client-auto-update workflow not working due to improper playbook file naming.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

This pull request is now in conflicts. Could you fix it @samuelarogbonlo? 🙏

@mergify mergify bot added the s:revision-needed The pull requests must be revised label Jul 24, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:revision-needed The pull requests must be revised labels Jul 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1052 (9255794) into main (bac24e6) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files          92       92           
  Lines       21589    21589           
=======================================
  Hits        20064    20064           
  Misses       1525     1525           
Flag Coverage Δ
tests 92.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Jul 25, 2023
@sea212 sea212 merged commit f48227a into main Jul 25, 2023
21 checks passed
@sea212 sea212 deleted the client-auto-update branch July 25, 2023 12:46
@sea212 sea212 added this to the v0.3.11 milestone Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants