Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit decompressor security miscellaneous comments #1402

Open
wants to merge 8 commits into
base: mkl-audit-fixes
Choose a base branch
from

Conversation

Chralt98
Copy link
Member

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:in-progress The pull requests is currently being worked on label Jan 15, 2025
@Chralt98 Chralt98 self-assigned this Jan 15, 2025
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Jan 16, 2025
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Jan 16, 2025
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Jan 16, 2025
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Jan 16, 2025
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Jan 16, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (mkl-audit-fixes@2ce829b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...binatorial-tokens/src/types/collection_id_error.rs 0.00% 4 Missing ⚠️
zrml/combinatorial-tokens/src/lib.rs 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             mkl-audit-fixes    #1402   +/-   ##
==================================================
  Coverage                   ?   93.50%           
==================================================
  Files                      ?      182           
  Lines                      ?    34722           
  Branches                   ?        0           
==================================================
  Hits                       ?    32467           
  Misses                     ?     2255           
  Partials                   ?        0           
Flag Coverage Δ
tests 93.50% <81.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:review-needed The pull request requires reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants