-
-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler warnings #4026
Fix compiler warnings #4026
Conversation
Things are still not settled in that area... could we remove the warning? |
for xtask subcommand to remove warnings about unknown compiler attributes.
as dependency, since the code we need can now be expressed using rusts `std` builtin types.
so the compiler doesn't complain about dead code any more.
across the codebase, as discovered by the rust compiler.
from `ClientInstruction` and all code attached to it.
Actually - I think these unused warnings were introduced by my recent changes with |
5b99248
to
0cedcfe
Compare
0cedcfe
to
418cb5d
Compare
418cb5d
to
d566a45
Compare
Sorry for the noise, but changes in
I suspect so, but I can't prove it without digging deeper. In any case, they're all gone now. I saw in your commit message for There's still the mystery around the CliPipe enum variant thingies I'm not quite sure of. It appears to do nothing much on the client side, but removing the code (and all of its appendages) entirely broke a lot of other stuff. So I followed the compilers recommendation and stubbed the |
After the recent rust toolchain upgrade, we started getting a bunch of warnings during compilations. It turns out they were mostly harmless, but still not pretty to look at.
This PR removes the current compiler warnings and makes
cargo x build
run warning-free. It does remove a bit of code to get there though. As of right now I've still got an enum in the Client implementation to weed through, where apparently we're not using internal fields in certain variants. I'm currently investigating whether these enum variants are still needed in the first place.@imsnif What's your stance on deleting "unused" code? In particular the functions
handle_right_mouse_release
andhandle_middle_mouse_release
are only used in tests, for example. We're only handling mouse hold/release for left clicks explicitly. Would you prefer I remove that code entirely, or mark it as#[cfg(test)]
so it sticks around in case we need it in the future?