This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Renaming ErrorHandler to ErrorHandlerMiddleware #191
Open
boesing
wants to merge
6
commits into
zendframework:develop
Choose a base branch
from
boesing:deprecation/error-handler-to-error-middleware
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Renaming ErrorHandler to ErrorHandlerMiddleware #191
boesing
wants to merge
6
commits into
zendframework:develop
from
boesing:deprecation/error-handler-to-error-middleware
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ErrorMiddleware` is just a drop-in replacement for the `ErrorHandler` to solve a naming conflict. As the `ErrorHandler` is implementing the `MiddlewareInterface`, it supposed to be called `ErrorMiddleware` instead.
The `ErrorHandler` should be removed in v4.
By just extending the `ErrorMiddleware`, we can remove the dedicated unit test and the duplicated code for the `ErrorHandler`
Actually, its an error handling middleware. Renaming to `ErrorHandlerMiddleware` is more beneficial as just `ErrorMiddleware`.
vaclavvanik
reviewed
Aug 19, 2019
@boesing I think there might be some references to this class in the documentation so we need update it. Other than that LGTM 👍 |
This repository has been closed and moved to laminas/laminas-stratigility; a new issue has been opened at laminas/laminas-stratigility#2. |
This repository has been moved to laminas/laminas-stratigility. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already mentioned in #190, there is a naming conflict in the
ErrorHandler
.I had some feedback of trainees which asked me, why the
ErrorHandler
ain't aRequestHandler
, as its name says.That made me think about the naming and I realized, its just because of the missing
Middleware
postfix.However, I'd like to rename the
ErrorHandler
toErrorHandlerMiddleware
to avoid future confusions about where the difference betweenRequestHandlerInterface
andMiddlewareInterface
is.