fix(ci): run build on tags (#1483)

* fix(ci): run build on tags Signed-off-by: Aaron Pham <[email protected]> * chore: update docker warning and not push on PR Signed-off-by: Aaron Pham <[email protected]> --------- Signed-off-by: Aaron Pham <[email protected]>
zenodotus280 · Oct 7, 2024 · 66d7dd8 · 66d7dd8
1 parent 313cef6
commit 66d7dd8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/docker-build-push.yaml b/.github/workflows/docker-build-push.yaml
@@ -3,7 +3,7 @@ name: Docker build & push image
 on:
   push:
     branches: [v4]
-  tags: ["v*"]
+    tags: ["v*"]
   pull_request:
     branches: [v4]
     paths:
@@ -78,7 +78,7 @@ jobs:
         id: build-and-push
         uses: docker/build-push-action@v6
         with:
-          push: true
+          push: ${{ github.event_name != 'pull_request' }}
           build-args: |
             GIT_SHA=${{ env.GITHUB_SHA }}
             DOCKER_LABEL=sha-${{ env.GITHUB_SHA_SHORT }}

diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:20-slim as builder
+FROM node:20-slim AS builder
 WORKDIR /usr/src/app
 COPY package.json .
 COPY package-lock.json* .