feat!: add wait/handle time to ProcessedMessage

zenstruck · Nov 10, 2024 · b983a6c · b983a6c
1 parent 53f7064
commit b983a6c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/config/doctrine/mapping/ProcessedMessage.orm.xml b/config/doctrine/mapping/ProcessedMessage.orm.xml
@@ -11,6 +11,8 @@
         <field name="dispatchedAt" column="dispatched_at" type="datetime_immutable" />
         <field name="receivedAt" column="received_at" type="datetime_immutable" />
         <field name="finishedAt" column="finished_at" type="datetime_immutable" />
+        <field name="waitTime" column="wait_time" type="integer" />
+        <field name="handleTime" column="handle_time" type="integer" />
         <field name="memoryUsage" column="memory_usage" type="integer" />
         <field name="transport" column="transport" />
         <field name="tags" column="tags" nullable="true" />

diff --git a/src/History/Model/ProcessedMessage.php b/src/History/Model/ProcessedMessage.php
@@ -37,6 +37,8 @@ abstract class ProcessedMessage
     private int $memoryUsage;
     private string $transport;
     private ?string $tags;
+    private int $waitTime;
+    private int $handleTime;
 
     /** @var class-string<\Throwable> */
     private ?string $failureType = null;
@@ -61,6 +63,8 @@ public function __construct(Envelope $envelope, Results $results, ?\Throwable $e
         $this->transport = $monitorStamp->transport();
         $this->tags = $tags->count() ? (string) $tags : null;
         $this->results = $results;
+        $this->waitTime = \max(0, $this->receivedAt->getTimestamp() - $this->dispatchedAt->getTimestamp());
+        $this->handleTime = \max(0, $this->finishedAt->getTimestamp() - $this->receivedAt->getTimestamp());
 
         if ($retryStamp = $envelope->last(RedeliveryStamp::class)) {
             $this->attempt += $retryStamp->getRetryCount();
@@ -146,17 +150,17 @@ final public function isFailure(): bool
 
     final public function timeInQueue(): int
     {
-        return \max(0, $this->receivedAt->getTimestamp() - $this->dispatchedAt->getTimestamp());
+        return $this->waitTime;
     }
 
     final public function timeToHandle(): int
     {
-        return \max(0, $this->finishedAt->getTimestamp() - $this->receivedAt->getTimestamp());
+        return $this->handleTime;
     }
 
     final public function timeToProcess(): int
     {
-        return \max(0, $this->finishedAt->getTimestamp() - $this->dispatchedAt->getTimestamp());
+        return $this->waitTime + $this->handleTime;
     }
 
     final public function memoryUsage(): Bytes

diff --git a/src/History/Storage/ORMStorage.php b/src/History/Storage/ORMStorage.php
@@ -92,7 +92,7 @@ public function averageWaitTime(Specification $specification): ?float
     {
         $qb = $this
             ->queryBuilderFor($specification, false)
-            ->select('AVG(m.receivedAt - m.dispatchedAt)')
+            ->select('AVG(m.waitTime)')
         ;
 
         return (new EntityResult($qb))->asFloat()->first();
@@ -102,7 +102,7 @@ public function averageHandlingTime(Specification $specification): ?float
     {
         $qb = $this
             ->queryBuilderFor($specification, false)
-            ->select('AVG(m.finishedAt - m.receivedAt)')
+            ->select('AVG(m.handleTime)')
         ;
 
         return (new EntityResult($qb))->asFloat()->first();