Skip to content

Commit

Permalink
dts: arm: st: re-enable master can gating clock for can2
Browse files Browse the repository at this point in the history
Commit 57723cf ("dts: arm: st: Refactor DTSI files to use macro"),
which replaced raw hex codes by using STM32_CLOCK macro, causes
regression in the case of the CAN device where the previous raw value
contained more than one bit set to 1. The macro is in fact correct only
for values with a single bit set. In all other cases, raw values must
continue to be used.

Tested on STM32F429I-DISC1 board

Fixes: 57723cf
Co-authored-by: Michael Trimarchi <[email protected]>
Signed-off-by: Dario Binacchi <[email protected]>
  • Loading branch information
2 people authored and kartben committed Jan 28, 2025
1 parent 5db74f2 commit 2c3294b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion dts/arm/st/f1/stm32f105.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
interrupts = <63 0>, <64 0>, <65 0>, <66 0>;
interrupt-names = "TX", "RX0", "RX1", "SCE";
/* also enabling clock for can1 (master instance) */
clocks = <&rcc STM32_CLOCK(APB1, 26U)>;
clocks = <&rcc STM32_CLOCK_BUS_APB1 0x06000000>;
status = "disabled";
};

Expand Down
2 changes: 1 addition & 1 deletion dts/arm/st/f4/stm32f405.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
interrupts = <63 0>, <64 0>, <65 0>, <66 0>;
interrupt-names = "TX", "RX0", "RX1", "SCE";
/* also enabling clock for can1 (master instance) */
clocks = <&rcc STM32_CLOCK(APB1, 26U)>;
clocks = <&rcc STM32_CLOCK_BUS_APB1 0x06000000>;
master-can-reg = <0x40006400>;
status = "disabled";
};
Expand Down
2 changes: 1 addition & 1 deletion dts/arm/st/f4/stm32f412.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@
interrupts = <63 0>, <64 0>, <65 0>, <66 0>;
interrupt-names = "TX", "RX0", "RX1", "SCE";
/* also enabling clock for can1 (master instance) */
clocks = <&rcc STM32_CLOCK(APB1, 26U)>;
clocks = <&rcc STM32_CLOCK_BUS_APB1 0x06000000>;
master-can-reg = <0x40006400>;
status = "disabled";
};
Expand Down
2 changes: 1 addition & 1 deletion dts/arm/st/f4/stm32f446.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
interrupts = <63 0>, <64 0>, <65 0>, <66 0>;
interrupt-names = "TX", "RX0", "RX1", "SCE";
/* also enabling clock for can1 (master instance) */
clocks = <&rcc STM32_CLOCK(APB1, 26U)>;
clocks = <&rcc STM32_CLOCK_BUS_APB1 0x06000000>;
master-can-reg = <0x40006400>;
status = "disabled";
};
Expand Down

0 comments on commit 2c3294b

Please sign in to comment.