-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing: add user event trace #74037
tracing: add user event trace #74037
Conversation
a993d24
to
d1c8540
Compare
@nashif please take a look |
yep, looking at this. |
d1c8540
to
e720853
Compare
Rebased to clear conflicts |
I can see this being useful for quickly looking at some tracing points, but the reality is the string name here will limit how many points can be sent over a wire quickly I'd think, perhaps renaming this to NAMED_EVENT or so would be more apt, as users are welcome to add tracing points of their own with their own TIDs ideally. |
IE names like:
I have no issue with this change- the primary goals here are to provide an example for users of how to extend tracing support, and to add a simple function to quickly extend tracing while debugging an issue |
e720853
to
487073d
Compare
@teburd wanted to clarify here, were you asking me to make this name change? Happy to do so if you are |
It's not a blocker but I do think the name would, at least for me, signal the right things better than the current user event naming. I leave it up to you @danieldegrasse as you are the author. |
Add support for a "named event" trace. This trace is intentionally not used by the system. The purpose of this trace is to allow driver or application developers to quickly add tracing for events for debug purposes, and to provide an example of how tracing subsystems can be extended with additional trace identifiers. Signed-off-by: Daniel DeGrasse <[email protected]>
Document availability of sys_trace_user_event, for users who are trying to add custom trace events to their application. Signed-off-by: Daniel DeGrasse <[email protected]>
Add usage example for sys_trace_user_event, to demonstrate how users could add tracing functionality to their application. Signed-off-by: Daniel DeGrasse <[email protected]>
No problem with the name change- I've update the PR |
487073d
to
99816b3
Compare
@nashif could you take a look at this? |
@danieldegrasse sorry about the delay, will do asap and in time for 4.0.0 |
Add support for a "user event" trace. This trace is intentionally not
used by the system. The purpose of this trace is to allow driver or
application developers to quickly add tracing for events for debug
purposes, and to provide an example of how tracing subsystems can be
extended with additional trace identifiers.