tests: build_all: sensor: enable iis328dq and wsen-pads #78655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separating declarations of variables not referenced with #ifdef when CONFIG_IIS328DQ_THRESHOLD is disabled. Signed-off-by: TOKITA Hiroshi <[email protected]>
Add trigger support for iis328dq build all sensor tests. Signed-off-by: TOKITA Hiroshi <[email protected]>
Fix to eliminate warnings caused by type mismatch. Signed-off-by: TOKITA Hiroshi <[email protected]>
Add trigger support for wsen-pads build all sensor tests. Signed-off-by: TOKITA Hiroshi <[email protected]>
zephyrbot
requested review from
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda and
yperess
| @@ -175,8 +175,10 @@ static void iis328dq_handle_interrupt(const struct device *dev) | |||
| struct iis328dq_data *data = dev->data; | |||
| stmdev_ctx_t *ctx = (stmdev_ctx_t *)&cfg->ctx; | |||
| iis328dq_status_reg_t status; | |||
| #ifdef CONFIG_IIS328DQ_THRESHOLD | |||
There was a problem hiding this comment.
The variables should probably be marked as __maybe_unused. See https://www.kernel.org/doc/html/latest/process/coding-style.html section 21.
There was a problem hiding this comment.
Thank you for your review.
I applied your suggestion.
There was a problem hiding this comment.
Zephyr convention is to use the ifdef
soburi
force-pushed
the
build_all_sensor_iis328dq_wsen_pads
branch
from
a02f579
to
a8672d8
Compare
jeppenodgaard
previously approved these changes
Sep 19, 2024
MaureenHelm
requested changes
Sep 20, 2024
Comment on lines
178
to
179
| __maybe_unused iis328dq_int1_src_t sources1; | ||
| __maybe_unused iis328dq_int2_src_t sources2; |
There was a problem hiding this comment.
Zephyr convention is to use an ifdef
There was a problem hiding this comment.
Restored.
Thank you for your check.
soburi
dismissed stale reviews from avisconti and jeppenodgaard
via
a02f579
soburi
force-pushed
the
build_all_sensor_iis328dq_wsen_pads
branch
from
a8672d8
to
a02f579
Compare
MaureenHelm
approved these changes
Sep 23, 2024
ubieda
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wsen-pads:
Fix to eliminate warnings caused by type mismatch.
iis328dq:
Separating declarations of variables not referenced with #ifdef
when CONFIG_IIS328DQ_THRESHOLD is disabled