dts: bindings: timer: move a few counter bindings to correct location #81473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldegrasse
requested review from
manuargue,
mmahadevan108 and
dleach02
as code owners
zephyrbot
added
size: XS
zephyrbot
requested review from
bperseghetti,
Dat-NguyenDuy,
dbaluta,
decsny,
MarkWangChinese and
PetervdPerk-NXP
A few bindings in the timer directory (for kernel timing sources) were being used for counters (which can have alarms set, and have a distinct API). Move these bindings to the counters directory. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
force-pushed
the
cleanup/timer-bindings
branch
from
9b1864c
to
3a09dd2
Compare
danieldegrasse
requested review from
jimmyzhe,
yonsch,
anangl and
nandojve
as code owners
zephyrbot
added
platform: Raspberry Pi Pico
nandojve
approved these changes
Nov 16, 2024
kartben
approved these changes
Nov 18, 2024
manuargue
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
I'm ok with the change, but what would be the right place for hw timers that could be used either as a system timer or as a counter? perhaps the binding is defined in one place and the other binding inherits from it?
Currently there's only a counter driver for this hw counter, but in the future we may introduce a system timer driver as well.
There was a problem hiding this comment.
That is a good question. Personally, I would lean towards the timer folder, but I am not sure if it matters too much. The reason for this PR was that I got myself confused when looking at some counter drivers, and assumed they were timer drivers because of their binding location.
@decsny any preference here?
mmahadevan108
approved these changes
Nov 19, 2024
dleach02
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few bindings in the timer directory (for kernel timing sources) were being used for counters (which can have alarms set, and have a distinct API). Move these bindings to the counters directory.
Bindings found with: