Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: twister: split publishing results out of main workflow #81516

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

nashif
Copy link
Member

@nashif nashif commented Nov 18, 2024

Move publishing data to ES to a workflow_run step. This way we can
change the main workflow to use pull_request instead of
pull_request_target.

Signed-off-by: Anas Nashif [email protected]

fabiobaltieri
fabiobaltieri previously approved these changes Nov 18, 2024
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

stephanosio
stephanosio previously approved these changes Nov 18, 2024
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will not block this since it is not actually changing the twister workflow to pull_request -- when we do that in the future, we need to make sure that the triggering workflow run is validated, similar to how it is done in doc-publish-pr.

@nashif
Copy link
Member Author

nashif commented Nov 18, 2024

Will not block this since it is not actually changing the twister workflow to pull_request -- when we do that in the future, we need to make sure that the triggering workflow run is validated, similar to how it is done in doc-publish-pr.

that split workflow_run should not run on pull_requests though.

Move publishing data to ES to a workflow_run step. This way we can
change the main workflow to use pull_request instead of
pull_request_target.

Signed-off-by: Anas Nashif <[email protected]>
Use workflow_call to allow for different type of nodes depending on
event.

On push, we do not need to use zephyr runners, GH runners are enough and
are much faster to deploy and start.

This resolves an issue where push jobs will have to be queued for a
longer time waiting for the prep step, once the prep step is done, we
will have to wait one more time in the queue for requested nodes.

This should speed up execution of push events in CI.

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif merged commit ac08aca into zephyrproject-rtos:main Nov 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants