Fix Back to Home button in global error #456
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 build.zip [updated at May 8, 4:43:16 PM UTC] |
| @@ -131,7 +133,7 @@ export function ViewError({ | |||
| if (pageTemplateType !== 'dialog') { | |||
| navigate('/'); | |||
| } | |||
| window.location.reload(); | |||
There was a problem hiding this comment.
Can something break because we're no longer reloading the page?
There was a problem hiding this comment.
Good question. I'll check
There was a problem hiding this comment.
I don't know, tbh.
My logic was: we are updating a prop for ErrorBoundary, so it should be updated after going to home screen. However, I think window.reload can be helpful
There was a problem hiding this comment.
If we're reloading, what does onRetry accomplish?
There was a problem hiding this comment.
This looked like GlobalBoundary wasn't updated during this reload properly. I will check again
zerts
force-pushed
the
fix/fix-global-error-screen
branch
from
c39f893
to
55068bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.