PoC: Sidepanel #596
PoC: Sidepanel #596
Conversation
everdimension
commented
Aug 21, 2024
•
everdimension
commented
- When sidepanel is open, react to updated tab origin and to "chain changed" event
- Adapt layout for sidepanel
- What if dapp request comes NOT from the current (active) tab? Handle this case
everdimension
force-pushed
the
poc/sidepanel-api-wip
branch
2 times, most recently
from
2d3e200
to
7f7da8b
Compare
React to active tab change, URL change and dapp chain change
everdimension
force-pushed
the
poc/sidepanel-api-wip
branch
from
7f7da8b
to
a0fae94
Compare
|
📦 build.zip [updated at Sep 3, 7:54:32 PM UTC] |
everdimension
force-pushed
the
poc/sidepanel-api-wip
branch
from
f729954
to
6a223fa
Compare
|
In Arc if you choose "Prefer Sidepanel", extension goes into broken state. Cause sidepanel is not supported, so nothing opens. |
|
If you prefer sidebar and sign/send/connect screen opens, you lose context and route where you were before in extension. |
|
If I prefer sidebar, close it and try to sign transaction, sidebar doesn't open on this request -> I need to do it manually. |
| import { emitter } from '../events'; | ||
|
|
||
| export function navigateProgrammatically(params: { pathname: string }) { | ||
| emitter.emit('navigationRequest', params); |
There was a problem hiding this comment.
why do we need this wrapper over navigate?
There was a problem hiding this comment.
because navigate works only in context of react router
we should migrate to creating a router instance later: https://reactrouter.com/en/main/upgrading/v6-data
| navigationRequest: (params: { pathname: string }) => void; | ||
| // this event means that some dapp-related data is updated (e.g. current account, chain) | ||
| ethereumEvent: () => void; | ||
| 'sidepanel/activeTabUpdated': () => void; |
There was a problem hiding this comment.
Should this event be called just activeTabUpdated?
|
After choosing "Open sidepanel once" and closing it, dapp requests don't open popup |
| @@ -0,0 +1,3 @@ | |||
| export function isSidepanelSupported() { | |||
| return globalThis.chrome && 'sidePanel' in chrome; | |||
There was a problem hiding this comment.
Hm, interesting, why this didn't prevent sidebar controls from appearing in Arc?
There was a problem hiding this comment.
Yeah, looks like a bug in Arc
| // it's ok, it might've not been open at all | ||
| } | ||
| const url = getSidepanelUrl(); | ||
| if (!currentWindowId) { |
There was a problem hiding this comment.
Should we move this condition to the beginning of this function? To avoid closing sidepanel without opening it next
There was a problem hiding this comment.
Hm, I'm thinking that if user pressed a shortcut and sidepanel is opened and it's possible to close it, it should be closed. That way the user interaction won't seem broken
everdimension
force-pushed
the
poc/sidepanel-api-wip
branch
from
d896c97
to
8c570a8
Compare
|
Closed in favor of #617 |
