Get referral code from the web app when onboarding invitee #618
Conversation
|
📦 build.zip [updated at Oct 11, 1:46:58 PM UTC] |
| import * as styles from './styles.module.css'; | ||
| import { WebAppMessageHandler } from './WebAppMessageHandler'; | ||
|
|
||
| const DEBUG_INVITEE_FLOW = true; |
There was a problem hiding this comment.
Do not forget to remove before merge
| } | ||
|
|
||
| function setReferralCode(_referralCode: string) { | ||
| // save referralCode |
There was a problem hiding this comment.
Here we also need not to safe incorrect code to avoid softlock state for the user who clicked on incorrect link
There was a problem hiding this comment.
Now referral code is checked on the webapp side, so it should be safe to just save it here as is
There was a problem hiding this comment.
I think, doublecheck will not harm :)
There was a problem hiding this comment.
Extension should be more reliable then web
There was a problem hiding this comment.
Updated ✅ Response will fail in case of incorrect referral code. The saveReferrer function is commented out because its implementation is already a part of my other PR
| : 'https://app.zerion.io' | ||
| ); | ||
|
|
||
| enum WebAppCallbackMethod { |
There was a problem hiding this comment.
Aren't enums considered deprecated?
There was a problem hiding this comment.
Ah, right, changed to just type ✅
There was a problem hiding this comment.
Not really, some consider them bad, some don't... I think in this context its not a big deal: I just wanted to have some "sum"-type to enumerate possible callback methods
| } | ||
| } | ||
|
|
||
| export function WebAppMessageHandler({ path }: { path: string }) { |
| return value as RemoteConfig[K]; | ||
| }, | ||
| useErrorBoundary: false, | ||
| cacheTime: 0, |
There was a problem hiding this comment.
There was a problem hiding this comment.
removed cacheTime: 0, added staleTime: 8000 ✅
| return value as RemoteConfig[K]; | ||
| }, | ||
| useErrorBoundary: false, | ||
| staleTime: 10000, |
There was a problem hiding this comment.
Do we need to provide suspense here?
Hope this will not lead to ui blinking
There was a problem hiding this comment.
✅ Yep, let's have suspense: false
| isLoading: isLoadingRemoteConfigValue, | ||
| } = useRemoteConfigValue('extension_referral_program'); | ||
|
|
||
| if (isLoadingRemoteConfigValue) { |
There was a problem hiding this comment.
If we use isLoading, we can set suspense: false inside useQuery
|
|
||
| const ZERION_WEB_APP_URL = new URL( | ||
| process.env.NODE_ENV === 'development' | ||
| ? 'http://localhost:3000' |
There was a problem hiding this comment.
Looks like this should be a var inside .env file
There was a problem hiding this comment.
Agree, or just use hardcoded 'https://app.zerion.io', and localhost link shouldn't be commited
Whichever's easier
There was a problem hiding this comment.
I don't think we need https://localhost:3000 anymore (since the other PR is already merged) ✅ Updated
|
|
||
| type WebAppCallbackMethod = 'set-referral-code'; | ||
|
|
||
| interface WebAppMessage<T = unknown> { |
There was a problem hiding this comment.
We don't use generic value of this interface anywhere. But this is probably not a problem.
There was a problem hiding this comment.
Let's just have params?: unknown for now ✅
To test this PR you'll need https://github.com/zeriontech/pulse-frontend/pull/3331