Avoid doing IO operations on Android main thread #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Jan 9, 2025
| @@ -17,54 +17,6 @@ enum DeliveryMode | |||
| DATAGRAM, | |||
| DATAGRAM_BATCH; | |||
|
|
|||
| ObjectPrx apply(ObjectPrx prx) | |||
There was a problem hiding this comment.
Moved the logic to the only place that was used.
pepone
commented
Jan 9, 2025
| // Create a key manager manager factory that uses the certificates from our KeyStore. | ||
| KeyManagerFactory keyManagerFactory = | ||
| KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm()); | ||
| keyManagerFactory.init(keyStore, "password".toCharArray()); |
There was a problem hiding this comment.
Required for the client to provide a certificate, the hello server requires a client certificate by default.
pepone
commented
Jan 9, 2025
| } | ||
| ObjectPrx prx = _communicator.stringToProxy(s); | ||
| prx = _mode.apply(prx); | ||
| var prx = HelloPrx.createProxy( |
There was a problem hiding this comment.
Simplified to use createProxy.
pepone
commented
Jan 9, 2025
| @@ -91,8 +92,6 @@ else if(m.what == MSG_EXCEPTION || m.what == MSG_RESPONSE) | |||
| { | |||
| InitializationData initData = new InitializationData(); | |||
|
|
|||
| initData.executor = (Runnable runnable, Connection connection) -> _uiHandler.post(runnable); | |||
There was a problem hiding this comment.
We don't want all up-calls to run on the UI thread, this can result in NetworkOnMainThreadException.
For example I got this one:
android.os.NetworkOnMainThreadException
at android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1675)
at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:54)
at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
at sun.nio.ch.IOUtil.write(IOUtil.java:51)
at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:512)
at com.zeroc.Ice.StreamSocket.write(StreamSocket.java:176)
at com.zeroc.Ice.StreamSocket.write(StreamSocket.java:133)
at com.zeroc.Ice.TcpTransceiver.write(TcpTransceiver.java:44)
at com.zeroc.Ice.IdleTimeoutTransceiverDecorator.write(IdleTimeoutTransceiverDecorator.java:62)
at com.zeroc.Ice.ConnectionI.write(ConnectionI.java:2525)
at com.zeroc.Ice.ConnectionI.sendMessage(ConnectionI.java:1938)
at com.zeroc.Ice.ConnectionI.sendAsyncRequest(ConnectionI.java:334)
at com.zeroc.Ice.OutgoingAsync.invokeRemote(OutgoingAsync.java:130)
at com.zeroc.Ice.ConnectRequestHandler.flushRequestsImpl(ConnectRequestHandler.java:212)
at com.zeroc.Ice.ConnectRequestHandler.flushRequests(ConnectRequestHandler.java:193)
at com.zeroc.Ice.ConnectRequestHandler.setConnection(ConnectRequestHandler.java:93)
at com.zeroc.Ice.RoutableReference$3.setConnection(RoutableReference.java:703)
at com.zeroc.Ice.OutgoingConnectionFactory$ConnectCallback.setConnection(OutgoingConnectionFactory.java:711)
at com.zeroc.Ice.OutgoingConnectionFactory.finishGetConnection(OutgoingConnectionFactory.java:477)
at com.zeroc.Ice.OutgoingConnectionFactory.-$$Nest$mfinishGetConnection(Unknown Source:0)
at com.zeroc.Ice.OutgoingConnectionFactory$ConnectCallback.connectionStartCompleted(OutgoingConnectionFactory.java:654)
at com.zeroc.Ice.ConnectionI.upcall(ConnectionI.java:827)
at com.zeroc.Ice.ConnectionI$4.run(ConnectionI.java:812)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:205)
bernardnormier
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Android hello demo to avoid starting async invocations on the main thread. With 3.8 this would result in
NetworkOnMainThreadException.